Skip to content

MainWindow: DRY appending components to listbox #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryonakano merged 1 commit into from
Dec 2, 2025
Merged

MainWindow: DRY appending components to listbox #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 25 additions & 65 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,26 +134,12 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
var component_table = new HashTable<string, AppStream.Component> (str_hash, str_equal);

appstream_pool.get_components_by_id (app).as_array ().foreach ((component) => {
var url = component.get_url (AppStream.UrlKind.BUGTRACKER);
if (url == null) {
// Ignore components without a bugtracker URL because rows that just show
// a component name and can't take users to report issues are useless
warning ("BUGTRACKER URL is not set in the component '%s'", component.name);
if (component_table[component.id] != null) {
return;
}

if (component_table[component.id] == null) {
component_table[component.id] = component;

var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.DEFAULT_APPS,
url
);

listbox.append (repo_row);
}
component_table[component.id] = component;
append_row_from_component (component, DEFAULT_APPS);
});
}

Expand All @@ -162,64 +148,19 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
components.foreach ((component) => {
// FIXME: This should use kind != DESKTOP_APP but some metainfo is currently inaccurate
if (component.kind != ADDON && !(component.id in app_entries)) {
var url = component.get_url (AppStream.UrlKind.BUGTRACKER);
if (url == null) {
// Ignore components without a bugtracker URL because rows that just show
// a component name and can't take users to report issues are useless
warning ("BUGTRACKER URL is not set in the component '%s'", component.name);
return;
}

var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.SYSTEM,
url
);

listbox.append (repo_row);
append_row_from_component (component, SYSTEM);
}
});

placeholder_stack.visible_child = placeholder;
});

appstream_pool.get_components_by_extends ("io.elementary.settings").as_array ().foreach ((component) => {
var url = component.get_url (AppStream.UrlKind.BUGTRACKER);
if (url == null) {
// Ignore components without a bugtracker URL because rows that just show
// a component name and can't take users to report issues are useless
warning ("BUGTRACKER URL is not set in the component '%s'", component.name);
return;
}

var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.SETTINGS,
url
);

listbox.append (repo_row);
append_row_from_component (component, SETTINGS);
});

appstream_pool.get_components_by_extends ("io.elementary.wingpanel").as_array ().foreach ((component) => {
var url = component.get_url (AppStream.UrlKind.BUGTRACKER);
if (url == null) {
// Ignore components without a bugtracker URL because rows that just show
// a component name and can't take users to report issues are useless
warning ("BUGTRACKER URL is not set in the component '%s'", component.name);
return;
}

var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
Category.PANEL,
url
);

listbox.append (repo_row);
append_row_from_component (component, PANEL);
});
} catch (Error e) {
critical (e.message);
Expand Down Expand Up @@ -365,6 +306,25 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
});
}

private void append_row_from_component (AppStream.Component component, Feedback.MainWindow.Category category) {
var url = component.get_url (AppStream.UrlKind.BUGTRACKER);
if (url == null) {
// Ignore components without a bugtracker URL because rows that just show
// a component name and can't take users to report issues are useless
warning ("BUGTRACKER URL is not set in the component '%s'", component.name);
return;
}

var repo_row = new RepoRow (
component.name,
icon_from_appstream_component (component),
category,
url
);

listbox.append (repo_row);
}

private void launch_from_row (RepoRow row) {
var uri_launcher = new Gtk.UriLauncher (row.url);
uri_launcher.launch.begin (null, null, (obj, res) => {
Expand Down