WifiInterface: clean up wifi_activate_cb #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
requested changes
Dec 20, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
LGTM, only a minor comment
| } | ||
|
|
||
| private async void wifi_activate_cb (WifiMenuItem i) { | ||
| if (device == null) { |
Member
There was a problem hiding this comment.
Is it expected behavior that device can be null? If so we shouldn't use required because that will print a warning
Member
Author
There was a problem hiding this comment.
@leolost2605 I don't think it's expected no. I think theoretically this class can't be constructed without a device
leolost2605
approved these changes
Jan 14, 2026
danirabbit
deleted the
danirabbit/wifiinterface-wifiactivatecb-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiresis_secured, we don't re-use it