Adding in functionality to remove objects when they're removed from source bucket#8
Open
nkitmitto wants to merge 2 commits intoeleven41:masterfrom
Open
Adding in functionality to remove objects when they're removed from source bucket#8nkitmitto wants to merge 2 commits intoeleven41:masterfrom
nkitmitto wants to merge 2 commits intoeleven41:masterfrom
Conversation
mwhouser
requested changes
May 12, 2017
Contributor
mwhouser
left a comment
mwhouser
left a comment
There was a problem hiding this comment.
Some minor changes required.
However, this change also needs to be "opt-in" using a bucket tag (like the target bucket). The reason being that existing users don't have objects being deleted. If someone updates their Lambda function, then they need to explicitly decide they want the new functionality.
| console.log(record); | ||
|
|
||
| console.log(eventName); | ||
| if (eventName == "ObjectRemoved:DeleteMarkerCreated") { |
Contributor
There was a problem hiding this comment.
What about non-versioned S3 buckets? Is this same event triggered or is it different?
| callback(); | ||
| } | ||
| }); | ||
| if (eventName == "ObjectCreated:Put") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in functionality to remove objects when they're removed from source bucket