Fix for remote code execution #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP7 warnings in DA code * Additional attributes support
fgm
suggested changes
Oct 10, 2017
| $stats[$key] = $value - $array[$key]; | ||
| } | ||
|
|
||
| if (!isset($array[$key])) |
|
|
||
| # Make sure we're dealing with a real number | ||
| $v = $array[$key]; | ||
| if (!is_float($v) && !is_int($v)) |
Contributor
There was a problem hiding this comment.
Better add braces here (PSR-2 § 5)
| <span class="left setting help" title="Internal name : evicted_unfetched
Items evicted from LRU that were never touched by get/incr/append/etc">Evicted unfetched</span> | ||
| <?php echo (isset($stats['evicted_unfetched'])) ? Library_Data_Analysis::hitResize($stats['evicted_unfetched']) : 'N/A on ' . $stats['version']; ?> | ||
| </div> | ||
|
|
Contributor
There was a problem hiding this comment.
While useful, this block seems unrelated with the security issue. Removing it would make the PR smaller, hence easier to review and merge.
Author
|
I have created new pull request, using separated branch... let's use this one pls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly fix for the exploit described in
https://rstforums.com/forum/topic/85493-phpmemcachedadmin-122-remote-code-execution/