Skip to content

don't build a symbol that is already in the state #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjheilmann merged 1 commit into from
Dec 31, 2025
Merged

don't build a symbol that is already in the state #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/grpc_reflection/service/builder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ defmodule GrpcReflection.Service.Builder do
symbol: Enum.find(fields, fn f -> f.name == name end).type_name
}
end)
|> Enum.reject(fn %{symbol: s} -> s == nil end)
|> Enum.reject(fn %{symbol: s} -> is_nil(s) or State.has_symbol?(state, s) end)
|> Enum.reduce(state, fn %{mod: mod, symbol: symbol}, state ->
symbol = Util.trim_symbol(symbol)

Expand Down
2 changes: 1 addition & 1 deletion test/service/builder_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,12 @@ defmodule GrpcReflection.Service.BuilderTest do
assert %State{services: [WrappedService]} = tree
end

@tag skip: "Recursive message structure currently fails to parse"
test "handles a recursive message structure" do
assert {:ok, tree} = Builder.build_reflection_tree([RecursiveMessage.Service.Service])

assert tree.files |> Map.keys() |> Enum.sort() == [
"recursive_message.Reply.proto",
"recursive_message.Request.proto",
"recursive_message.Service.proto"
]

Expand Down