Fix Elixir 1.19 type system warnings #490
Conversation
* Add struct pattern matches to fix type warnings in Connection, CLI, and Generator modules * Update CI matrix with OTP 28.x and Elixir 1.19.x support * Rename erlpack_notypes.ex to erlpack_notypes_test.exs * Fix unreachable clause warning in report_exception_test.exs * Bump version to v1.0.0-rc.2
grpc_client/CHANGELOG.md
Outdated
| @@ -1,5 +1,23 @@ | |||
| # Changelog | |||
|
|
|||
| ## v1.0.0-rc.2 (2026-01-09) | |||
There was a problem hiding this comment.
I would remove this and keep it as rc.1 since this version hasn't been released yet. Therefore, this change would fall within the scope of rc.1.
|
Doing the changelogs now |
nshkrdotcom
force-pushed
the
fix-elixir-1.19-warnings
branch
from
be741f9 to
26ee053
Compare
|
Ugh, sorry, did a force to avoid too many commits. I'll slow down next time. |
grpc_client/CHANGELOG.md
Outdated
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fix Elixir 1.19 type system warnings for struct updates in Connection module |
There was a problem hiding this comment.
Not sure if I'd call these bug fixes. Definitely not a blocker
grpc_client/CHANGELOG.md
Outdated
| ### Bug fixes | ||
|
|
||
| * Fix Elixir 1.19 type system warnings for struct updates in Connection module | ||
| * Rename erlpack_notypes.ex to erlpack_notypes_test.exs to follow test naming convention |
There was a problem hiding this comment.
I think changelogs should be more like "highlight reels", so we can remove this line
grpc_server/CHANGELOG.md
Outdated
| ### Bug fixes | ||
|
|
||
| * Fix Elixir 1.19 type system warnings for struct updates in protoc CLI and generator | ||
| * Fix unreachable clause warning in report_exception_test.exs |
There was a problem hiding this comment.
Remove this as per the reasoning in the other changelog
| # Use Function.identity/1 to make value opaque to type inference | ||
| case Function.identity(:ok) do | ||
| :error -> :boom | ||
| end |
There was a problem hiding this comment.
maybe just convert this to an explicit raise instead? This seems like an error that will be caught again in the future.
.github/workflows/ci.yml
Outdated
| exclude: | ||
| - otp: 24.x | ||
| elixir: 1.19.x | ||
| - otp: 25.x | ||
| elixir: 1.19.x | ||
| - otp: 26.1.x | ||
| elixir: 1.19.x | ||
| - otp: 28.x | ||
| elixir: 1.15.x |
There was a problem hiding this comment.
probably cleaner to include the 1.19 + otp 28 pair instead
* Simplify CI matrix to use include instead of exclude for OTP 28.x/Elixir 1.19.x * Remove changelog entries for type warning fixes * Revert report_exception_test.exs to use direct raise * Apply YAML formatting fixes
3 participants
Summary
Notes
Fixes #489