Skip to content

Allow deleting last note #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamcons merged 2 commits into from
Nov 17, 2025
Merged

Allow deleting last note #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c59af1
touchups
teamcons Nov 17, 2025
f5739a4
allow deleting last note
teamcons Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Services/NoteManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public class Jorts.NoteManager : Object {
application.remove_window ((Gtk.Window)note);
note.close ();
note = null;
save_all ();
immediately_save ();
}

/*************************************************/
Expand All @@ -152,6 +152,7 @@ public class Jorts.NoteManager : Object {

private void immediately_save () {
var array = new Json.Array ();
print (open_notes.size.to_string ());

foreach (Jorts.StickyNoteWindow note in open_notes) {
var data = note.packaged ();
Expand Down
5 changes: 2 additions & 3 deletions src/Widgets/TextView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,9 @@ public class Jorts.TextView : Granite.HyperTextView {
/**
* Handler whenever a key is pressed, to see if user needs something and get ahead
* Some local stuff is deduplicated in the Ifs, because i do not like the idea of getting computation done not needed 98% of the time
*/
*/
private bool on_key_pressed (uint keyval, uint keycode, Gdk.ModifierType state) {
print ("char typed");


// If backspace on a prefix: Delete the prefix.
if (keyval == Gdk.Key.BackSpace) {
print ("backspace");
Expand Down
3 changes: 2 additions & 1 deletion windows/beware.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ Note about this one: Notes are not deleted on uninstall. Do not worry you wont l
- There is no setting to enable/disable Jorts starting with Windows.
The Installer sets it once, then it is between you and God.

- There may be some very edge case bugs.
- There may be some specific bugs.
As i write this, the looking glass in the search field of the emoji chooser does not show up. I dont fucking know why.
The app is starting slowly, because Windows has to load a lot of libraries Linux kinda has loaded already by default.

====
If you report bugs on Github, please mention that you are using the app on Windows, and ideally your level of technical knowledge so we can respond in a way that does not make you dissociate
Expand Down
2 changes: 1 addition & 1 deletion windows/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ BrandingText "Jorts ${version}, ${publisher} 2025"

!define MUI_FINISHPAGE_LINK "Source code and wiki"
!define MUI_FINISHPAGE_LINK_LOCATION "https://github.com/ellie-commons/jorts"
!define MUI_FINISHPAGE_RUN "\$SMPROGRAMS\\${app_name}\\${app_name}.lnk"
!define MUI_FINISHPAGE_RUN "\$INSTDIR\bin\io.github.ellie_commons.jorts.exe"

!insertmacro MUI_PAGE_WELCOME
!insertmacro MUI_PAGE_DIRECTORY
Expand Down