add the terminate_connection in iSCSIDriver #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the terminate_connection in iSCSIDriver for checking if the last volume is removed. If so, delete the initiator group which mapped with the volume
if return the whole snapshot the snapshot.name will not be able to be saved and cinder db will not be updated correctly. Only id and status need to be returned
Author
|
the second commit is for bugfix #5 |
shayh
reviewed
Apr 26, 2017
Contributor
shayh
left a comment
shayh
left a comment
There was a problem hiding this comment.
This flow is problematic,
- it will add more command sent to XMS.
- not sure what will happen if the last IG volumes terminates the connection and at the same time a new connection get's initialized.
| .num_of_mapped_volumes(self._get_ig_name(connector))) | ||
| if num_vols > 0: | ||
| return | ||
| else: |
Contributor
There was a problem hiding this comment.
would be simpler
if num_vols == 0:
...
Author
There was a problem hiding this comment.
I agree, but if we want to delete the initiator group, there is no other way but send the request to XMS.
It is not an error issue but how XtremIO driver should work.
By the way other storage vendor working like this, this is why I think that we should also work as so. Users maybe use multiple backend storage and keep all the storage have the same work will be friendly to user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the terminate_connection in iSCSIDriver for checking if the last
volume is removed. If so, delete the initiator group which mapped with
the volume