Skip to content

feat(progress-bar): add ProgressBar component#2011

Merged
AdrianArenal merged 2 commits intomainfrom
feat/xds-progress-bar
Feb 26, 2026
Merged

feat(progress-bar): add ProgressBar component#2011
AdrianArenal merged 2 commits intomainfrom
feat/xds-progress-bar

Conversation

@AdrianArenal
Copy link
Contributor

Screenshot 2026-02-25 at 16 50 27

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@AdrianArenal AdrianArenal requested a review from a team as a code owner February 25, 2026 15:50
@@ -0,0 +1,29 @@
/* Base */
@utility progress-bar {
--progress-bar-color-50: var(--xds-color-neutral-50);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid CSS variables given the right value in every case instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


/* Colors */
@utility progress-bar-* {
--progress-bar-color-50: --value(--color- * -50);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the rest of the components, don't use a new CSS variables.

Suggested change
--progress-bar-color-50: --value(--color- * -50);
& > .xds\:progress-bar-fill {
background-color: --value(--color- * -50)
}

Then we can removed --progress-bar-color-50.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! applied

Comment on lines 9 to 16
<span>sm</span>
<div class="xds:progress-bar xds:progress-bar-sm xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
<span>lg</span>
<div class="xds:progress-bar xds:progress-bar-lg xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span>sm</span>
<div class="xds:progress-bar xds:progress-bar-sm xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
<span>lg</span>
<div class="xds:progress-bar xds:progress-bar-lg xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
<div class="xds:flex xds:gap-8 xds:items-center xds:mr-16">
<span>sm</span>
<div class="xds:progress-bar xds:progress-bar-sm xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
</div>
<div class="xds:flex xds:gap-8 xds:items-center xds:mr-16">
<span>lg</span>
<div class="xds:progress-bar xds:progress-bar-lg xds:w-320">
<div class="xds:progress-bar-fill xds:w-[30%]" />
</div>
</div>

WDYT about adding a wrapper to show it better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied

@AdrianArenal AdrianArenal merged commit a971a4b into main Feb 26, 2026
3 checks passed
@AdrianArenal AdrianArenal deleted the feat/xds-progress-bar branch February 26, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants