feat(progress-bar): add ProgressBar component#2011
Merged
AdrianArenal merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
| @@ -0,0 +1,29 @@ | |||
| /* Base */ | |||
| @utility progress-bar { | |||
| --progress-bar-color-50: var(--xds-color-neutral-50); | |||
Member
There was a problem hiding this comment.
Try to avoid CSS variables given the right value in every case instead
Turito
reviewed
Feb 25, 2026
|
|
||
| /* Colors */ | ||
| @utility progress-bar-* { | ||
| --progress-bar-color-50: --value(--color- * -50); |
Contributor
There was a problem hiding this comment.
To be consistent with the rest of the components, don't use a new CSS variables.
Suggested change
| --progress-bar-color-50: --value(--color- * -50); | |
| & > .xds\:progress-bar-fill { | |
| background-color: --value(--color- * -50) | |
| } |
Then we can removed --progress-bar-color-50.
Contributor
Author
There was a problem hiding this comment.
nice catch! applied
Comment on lines
9
to
16
| <span>sm</span> | ||
| <div class="xds:progress-bar xds:progress-bar-sm xds:w-320"> | ||
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | ||
| </div> | ||
| <span>lg</span> | ||
| <div class="xds:progress-bar xds:progress-bar-lg xds:w-320"> | ||
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Suggested change
| <span>sm</span> | |
| <div class="xds:progress-bar xds:progress-bar-sm xds:w-320"> | |
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | |
| </div> | |
| <span>lg</span> | |
| <div class="xds:progress-bar xds:progress-bar-lg xds:w-320"> | |
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | |
| </div> | |
| <div class="xds:flex xds:gap-8 xds:items-center xds:mr-16"> | |
| <span>sm</span> | |
| <div class="xds:progress-bar xds:progress-bar-sm xds:w-320"> | |
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | |
| </div> | |
| </div> | |
| <div class="xds:flex xds:gap-8 xds:items-center xds:mr-16"> | |
| <span>lg</span> | |
| <div class="xds:progress-bar xds:progress-bar-lg xds:w-320"> | |
| <div class="xds:progress-bar-fill xds:w-[30%]" /> | |
| </div> | |
| </div> |
WDYT about adding a wrapper to show it better?
…color application
Turito
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request template
Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: