Skip to content

refactor: fix type issues #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrianArenal merged 3 commits into from
Feb 26, 2026
+10 −14
Merged

refactor: fix type issues #2012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f4061b
refactor: fix type issues
davidglezz Feb 25, 2026
e8eddfa
refactor: fix minor type issues in sort-list component
AdrianArenal Feb 26, 2026
a8f02d2
Merge branch 'main' into fix-minor-typeissues
AdrianArenal Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/x-components/src/components/column-picker/base-column-picker-dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
</template>

<script lang="ts">
import type { PropType } from 'vue'
import type Vue from 'vue'
import type { Component, PropType } from 'vue'
import { computed, defineComponent, onBeforeMount, ref, watch } from 'vue'
import { use$x } from '../../composables/use-$x'
import BaseDropdown from '../base-dropdown.vue'
Expand All @@ -57,7 +56,7 @@ export default defineComponent({
/** The value of the selected columns number. */
modelValue: Number,
/** The transition to use for opening and closing the dropdown. */
animation: [String, Object] as PropType<string | typeof Vue>,
animation: [String, Object] as PropType<string | Component>,
},
emits: ['update:modelValue'],
setup(props, { emit, slots }) {
Expand Down
4 changes: 2 additions & 2 deletions packages/x-components/src/x-modules/facets/components/facets/__tests__/facets.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Facet } from '@empathyco/x-types'
import type { DeepPartial, Dictionary } from '@empathyco/x-utils'
import type { DOMWrapper } from '@vue/test-utils'
import type Vue from 'vue'
import type { Component } from 'vue'
import type { RootXStoreState } from '../../../../../store/store.types'
import { mount } from '@vue/test-utils'
import { nextTick } from 'vue'
Expand Down Expand Up @@ -313,7 +313,7 @@ function renderFacetsComponent({
}

interface FacetsRenderOptions {
components?: Dictionary<typeof Vue>
components?: Dictionary<Component>
customFacetSlot?: string
facets?: Dictionary<Facet>
renderableFacets?: string
Expand Down
5 changes: 2 additions & 3 deletions packages/x-components/src/x-modules/search/components/sort-dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@

<script lang="ts">
import type { Sort } from '@empathyco/x-types'
import type { PropType } from 'vue'
import type Vue from 'vue'
import type { Component, PropType } from 'vue'
import { defineComponent, ref, watch } from 'vue'

import BaseDropdown from '../../../components/base-dropdown.vue'
Expand All @@ -57,7 +56,7 @@ export default defineComponent({
required: true,
},
/** The transition to use for opening and closing the dropdown. */
animation: [String, Object] as PropType<string | typeof Vue>,
animation: [String, Object] as PropType<string | Component>,
},
emits: ['change'],
setup(_, { emit }) {
Expand Down
5 changes: 2 additions & 3 deletions packages/x-components/src/x-modules/search/components/sort-list.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@

<script lang="ts">
import type { Sort } from '@empathyco/x-types'
import type { PropType } from 'vue'
import type Vue from 'vue'
import type { Component, PropType } from 'vue'
import type { VueCSSClasses } from '../../../utils/types'
import type { XEventsTypes } from '../../../wiring/events.types'
import { computed, defineComponent, watch } from 'vue'
Expand Down Expand Up @@ -56,7 +55,7 @@ export default defineComponent({
},
/** The transition to use for rendering the list. */
animation: {
type: [String, Object] as PropType<string | typeof Vue>,
type: [String, Object] as PropType<string | Component>,
default: () => 'ul',
},
},
Expand Down
5 changes: 2 additions & 3 deletions packages/x-components/src/x-modules/search/components/sort-picker-list.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@

<script lang="ts">
import type { Sort } from '@empathyco/x-types'
import type { PropType } from 'vue'
import type Vue from 'vue'
import type { Component, PropType } from 'vue'
import type { SortPickerItem } from './sort-picker-list.types'
import { computed, defineComponent, watch } from 'vue'
import BaseEventButton from '../../../components/base-event-button.vue'
Expand All @@ -49,7 +48,7 @@ export default defineComponent({
},
/** The transition to use for rendering the list. */
animation: {
type: [String, Object] as PropType<string | typeof Vue>,
type: [String, Object] as PropType<string | Component>,
default: () => 'div',
},
/** Class inherited by each sort button. */
Expand Down
Loading