Open
Conversation
k59319
pushed a commit
to mapilab/PDFsharp
that referenced
this pull request
Jun 15, 2020
Ability to construct generic fields for form field trees Page keys and CloneElement made visible to be used for a simple copy page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdfWriter.Write(PdfName value) no longer writes out '[' or ']' characters without replacing them with their hexadecimal formats. Lexer.ScanName() now detects invalid '[' and ']' delimiter characters.
While delimiter characters are not allowed to be in a name object, most Pdf readers can detect and correct when delimiter characters are found in a name object. PdfSharp should be able to do the same.
I would like to point out that that the improvement currently only deals with '[]' characters. Ideally it would cover all delimiter and white space characters and more cases.