Fix Name setter for Pdf.Contents.Objects.CName#86
Open
jeanbern wants to merge 2 commits intoempira:masterfrom
jeanbern:patch-1
Open
Fix Name setter for Pdf.Contents.Objects.CName#86jeanbern wants to merge 2 commits intoempira:masterfrom jeanbern:patch-1
jeanbern wants to merge 2 commits intoempira:masterfrom
jeanbern:patch-1
Conversation
The setter should be validating the input, not the existing value. As is, the CName(string name) constructor always throws an ArgumentNullException.
It passed the first check, but a change was also required for the second.
jafin
referenced
this pull request
in jafin/PdfSharpCore
Jun 4, 2022
…t private name. Credits original author @jeanbern empira/PDFsharp#86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter should be validating the input, not the existing value.
As is, the CName(string name) constructor always throws an ArgumentNullException.