Some valid JPEG files may not be loaded using XImage.FromFile()#332
Open
stogle wants to merge 1 commit intoempira:masterfrom
Open
Some valid JPEG files may not be loaded using XImage.FromFile()#332stogle wants to merge 1 commit intoempira:masterfrom
stogle wants to merge 1 commit intoempira:masterfrom
Conversation
Member
|
Thanks for the PR. Can you provide a JPEG file to replicate the issue fixed by the PR? |
Author
|
Hi @ThomasHoevel.
The .zip in the linked issue contained two examples. I have attached them here for convenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256.
Some JPEG files don't include any app headers at all (sometimes called "raw" JPEGs - not to be confused with RAW files). In my case, JPEGs captured by FlashCap sometimes didn't have them.
This PR makes app headers optional so that PDFsharp can successfully import them.