fleetctl: {load|unload|start|stop} and get unit code cleanups#7

Closed

tixxdz wants to merge 31 commits intocoreos-integrationfrom

tixxdz/fleet-code-cleaning-v1+1

Commits on Feb 24, 2016

test: added scripts for functional tests
kayrus
committed
Merge pull request #1430 from endocode/kayrus/docker_test
kayrus
committed
travis: bump go minor versions, add 1.6
kayrus
committed
Merge pull request #1440 from endocode/kayrus/bump_go_version_in_travis
kayrus
committed
fleetctl: avoid hard coding sleep time values inside calls
Djalal Harouni
committed
fleetctl:destroy: on destroy check if the unit does not exist
Djalal Harouni
committed
tests fleetctl destroy behavior

steveej
authored and
Djalal Harouni
committed
destroy_test: add a destroy test for non-existent units
Djalal Harouni
committed
fleetctl:test: add appendJobsForTests() helper to automatically append jobs
Djalal Harouni
committed
fleetctl:destroy_test: make the test more smarter by checking for race conditions
Djalal Harouni
committed
fleetctl:test: add commandTestResults struct and newFakeRegistryForCommands()
Djalal Harouni
committed
fleetctl:test: add some tests for fleetctl stop path
Djalal Harouni
committed
fleetctl:test: add some tests for fleetctl unload path
Djalal Harouni
committed
fleetctl:test: restore back sharedFlags.NoBlock when finishing
Djalal Harouni
committed
fleetctl:test: improve operation description for unload and stop tests
Djalal Harouni
committed
Merge pull request #1439 from endocode/tixxdz/fleet-destroy-and-tests-v1
tixxdz
committed

Commits on Feb 29, 2016

Commits on Mar 1, 2016

Commits on Mar 2, 2016

fleetctl: add tryWaitForUnitStates() and getBlockAttempts()
Djalal Harouni
committed
fleetctl: {load|start|stop|unload} use the tryWaitForUnitStates() and getBlockAttempts()
Djalal Harouni
committed
fleetctl: move logic to lookup a unit into getUnitFile() and getUnitFileFromTemplate()
Djalal Harouni
committed
fleetctl: inline getBlockAttempts() in tryWaitForUnitStates() calls
Djalal Harouni
committed
fleetctl: improve code comment about getUnitFileFromTemplate()
Djalal Harouni
committed
fleetctl: getBlockAttempts() standarise on negative meaning do not block
Djalal Harouni
committed
fleetctl:test: push tests for getBlockAttempts()
Djalal Harouni
committed
fleetctl: improve getUnitFile() error handling and add some documentation
Djalal Harouni
committed
fleetctl: for errors indicate that getUnitFileFromTemplate() tried both registry and filesystem
Djalal Harouni
committed
fleetctl: improve getUnitFile() and getUnitFileFromTemplate() Godoc
Djalal Harouni
committed
fleetctl: just inline getUnitInstanceInfo() and restore previous error messages
Djalal Harouni
committed