dynamic_modules: add dynamic modules support for udp listener filters #42820
+2,360
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-dm-udp-1
branch
9 times, most recently
from
fae638b to
c246058
Compare
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
agrawroh
force-pushed
the
feat-dm-udp-1
branch
from
c246058 to
eedf4c3
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-dm-udp-1
branch
from
eedf4c3 to
8c97aa9
Compare
mathetake
reviewed
Jan 5, 2026
mathetake
reviewed
Jan 5, 2026
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Jan 7, 2026
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
wbpcode
reviewed
Jan 7, 2026
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
Thanks for the update. ABI LGTM. And the code LGTM overall. It would be better to wait @mathetake to give another check because I didn't check the implementation very carefully.
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a new UDP Listener filter for Dynamic Modules. With this it should be possible to write new UDP Listener Filters similar to TCP.
Commit Message: dynamic_modules: add dynamic modules support for UDP listener filters
Additional Description: Adds support for a new UDP listener filter for Dynamic Modules.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added