Skip to content

Conversation

@pianiststickman
Copy link
Contributor

Commit Message: access_log: add formatter commands for endpoint IDs on internal listeners

Additional Description:

Adds the following commands:
%DOWNSTREAM_LOCAL_ADDRESS_ENDPOINT_ID%
%DOWNSTREAM_DIRECT_LOCAL_ADDRESS_ENDPOINT_ID%
%UPSTREAM_REMOTE_ADDRESS_ENDPOINT_ID%

Since endpoint ID on internal listeners is suggested as a way to encode destination IPs for tunnels, it is a useful formatter command.

Risk Level: low
Testing: CI
Docs Changes: included
Release Notes: changelog entry included
Platform Specific Features: n/a

…ners

Adds the following commands:
%DOWNSTREAM_LOCAL_ADDRESS_ENDPOINT_ID%
%DOWNSTREAM_DIRECT_LOCAL_ADDRESS_ENDPOINT_ID%
%UPSTREAM_REMOTE_ADDRESS_ENDPOINT_ID%

Since endpoint ID on internal listeners is suggested[1] as a way to encode
destination IPs for tunnels, it is a useful formatter command.

[1] https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/core/v3/address.proto.html#config-core-v3-envoyinternaladdress

Signed-off-by: Eugene Chan <eugenechan@google.com>
Signed-off-by: Eugene Chan <eugenechan@google.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #42861 was opened by pianiststickman.

see: more, trace.

@pianiststickman pianiststickman marked this pull request as ready for review January 5, 2026 23:21
@botengyao botengyao self-assigned this Jan 6, 2026
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice PR, thanks!

@agrawroh agrawroh merged commit 1116ae1 into envoyproxy:main Jan 6, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants