Updated elgohr/Publish-Docker-Github-Action to a supported version (v5)#7
Open
elgohr wants to merge 50 commits intoenwaytech:masterfrom
Open
Updated elgohr/Publish-Docker-Github-Action to a supported version (v5)#7elgohr wants to merge 50 commits intoenwaytech:masterfrom
elgohr wants to merge 50 commits intoenwaytech:masterfrom
Conversation
* Make lines truly instanced Make the lines component able to take multiple poses per marker. This will help us implement some markers that have different poses instead of different points. While we're at it, make the loading of colors into lines more efficient by passing a typed array directly to regl. Test plan: added a story, test that existing tests continue working. * Address comments
…#249) * No longer require colors to enable instancing * Remove memo from grid * Bump worldview to 0.2.4
Changelog: - Fixed zoom issue in plot panel. - Allow full-screen panel locking by holding `` ` `` + `shift` and clicking a panel. - In the Plot panel, we now default the "timestamp method" (`receiveTime` vs `header.stamp`) to the last used value. - Added ability to save playback speed to layout config. - Added ability to search panels by name. - Moved the filter feature in Diagnostic Summary panel and got rid of it in Diagnostic Detail panel. - Fixed issue so that navigating away from a new tab before it loads will still start data loading. - Fixed a memory leak in the 3D panel. - Added ability to plot timestamp values in Raw Messages and Plot panels. - Updated React to latest version. - In tests, enabled `restoreMocks`.
Changelog: - UI clean up in toolbar - Fix RandomAccessPlayer to prevent emitting old messages after seeking - Enable NodePlayground - Properly clip Autocomplete to bottom of the screen
) ## Summary For performance reasons we sometimes want to only render triangles when clicking. Add an option to allow this. Modify the command API somewhat to enable this. Also do a small cleanup: move all of the `createInstancedGetChildrenForHitmap` calls out of the render functions of commands. ## Test plan Added a story with this new behavior. ## Versioning impact Minor package increment needed.
* stop propagation workin * flow * misleading test * version bump, doc change
Changelog: - Added a new "Flat" mode to the 3D panel topic picker. Now when playing multiple bags in the "Flat" mode, bag1 topics are grouped under `Bag` and bag2 topics are grouped under `Bag 2 /webviz_bag_2`. In the "Flat" mode, you can temporarily toggle the topic's visibility by clicking the eye icon next to the edit icon. This is the first step in the ongoing work to improve multi-bag comparison in the 3D panel. - Sped up local bag reading by decompressing bag chunks ahead of playback. - Added support for negative slices in the topic path syntax, e.g. to get the last element of an array. - Added the ability to plot numerical values in Diagnostics - Detail panel. - Added ability to pan, zoom and do auto zoom in imageView panel. - Clicking on stacked objects is now automatically turned on in the 3D panel when playback is paused. If there are multiple clicked objects, the object id will be displayed in the context menu if available. - Added ability to toggle visibility of Plot panel's legends. - Implemented a workaround to runaway disk usage due to a Chrome bug, which has been causing very slow Webviz start up times. If possible, please clear out your local instance of IndexedDB on Webviz. - Fixed image panel with synchronized markers not loading data when seeking, by increasing the amount of data we load when seeking. - Fixed a `Time should never move backwards` error when seeking. - Fixed negative numbers showing incorrect colors in the State Transitions panel. cruise-automation#271
## Summary This particular block of code throws a lot of exceptions (`(regl) context lost `) when the OS occasionally resets the GPU (More [info here](https://www.khronos.org/webgl/wiki/HandlingContextLost)). Since it was running in `requestAnimationFrame`, our React Error Boundaries were not catching the error. ## Test plan I've been having a hard time reproducing this particular error. You basically have to intentionally over-utilize the GPU to get this to occur, but it's very inconsistent. ## Versioning impact Needs a minor bump.
…mation#279) CSS files directly imported from node_modules would cause an error when jest failed to parse them. CSS files were being handled in the `transforms`, but these are ignored for node_modules, so use `moduleNameMapper` instead.
Changelog: - Now we always show some data in panels upon first load, even if a `seek-to` URL query parameter is not given. - Replaced toggle action with delete action when showing flat selected topics in the 3D panel, and added option to allow different bag topic groups to have different topics (previously topics can't be unchecked unless they are removed from both bag1 and bag2 groups). - Various improvements to playback performance, including using threads for rendering images, a Playback Performance panel, more playback speed options, and other more minor improvements. - Added ability to view and export all point cloud fields upon clicking a point in the 3D panel. - Removed automatic playback when loading Webviz, in all cases. This simplifies Webviz's behavior and implementation. Just press the spacebar to start playback. - Fixed flicker of all panels when seeking. - Fixed bug where unhelpful errors were thrown when an invalid `?seek-to` parameter was given. - Fixed bug where bag data was not properly loaded. cruise-automation#281
Changes: - PointCloud2 topics can now be colored with a custom gradient, and the min/max value can be customized for both custom gradients and the default rainbow palette. - PointCloud2 automatic coloring now works correctly for negative values.
These docs were incorrect: they were based on an earlier version of the hitmap code. Update them to correct the hitmap usage.
Changelog: - In the 3D panel, moved "Flatten markers" from the topic selector to the panel settings since it's not associated with any topics. - Added ability to set min and max values for both x and y axes in the 2D Plot panel. - Added support for slices using global variables in the topic path syntax, e.g. to get $my_idx of an array. - Added ability to diff messages from 2 different topics in Raw Messages panel. - Added a warning when a topic in the 3D panel is in the non-root frame. Webviz has a known bug with applying transforms correctly when they are not in the root frame, so this change alerts users to that fact when it is affecting their view. - Fixed edge case where wrapping around playback to the start of the bag would miss messages which timestamp are at the very start of the bag. - Fixed inability to copy large messages to the clipboard in JSON format from the Raw Messages panel. - Fixed a Plot panel bug where looping through the bag caused it to crash. - Allow skip publishing in Node Playground by returning 'undefined'. - Fixed topics disappearing in the 3D panel flat topic list. - Fixed inability to play markers from webviz_bag_2 in the image panel. The webviz_bag_2 image topics in the image panel topic selector menu are also now grouped the same way that image topics from the first bag are. - Now we always show some data in panels upon first load, even if a seek-to URL query parameter is not given. - Various improvements to playback performance, including using threads for rendering images, a Playback Performance panel, more playback speed options, and other more minor improvements.
## Summary Adds a new `<GLText />` command which is API-compatible with `<Text />`. Instead of overlaying DOM nodes on top of Worldview, the text is rendered in GL so it can participate in occlusion. Rendering in GL is also much faster than managing many separate DOM elements; see the GLText docs page for a performance demo. All the necessary characters are rendered into a texture atlas using a [signed distance field](https://github.com/libgdx/libgdx/wiki/Distance-field-fonts) representation, then all characters from all children are drawn in a single draw call. More implementation details are explained in GLText.js.  Many thanks to the following resources/implementations/references which were helpful in informing this implementation! - Valve: [Improved Alpha-Tested Magnification for Vector Textures and Special Effects](https://steamcdn-a.akamaihd.net/apps/valve/2007/SIGGRAPH2007_AlphaTestedMagnification.pdf) - Mapbox: [Drawing Text with Signed Distance Fields in Mapbox GL](https://blog.mapbox.com/drawing-text-with-signed-distance-fields-in-mapbox-gl-b0933af6f817) - Otto Chrons: [Text rendering in OpenGL](http://hack.chrons.me/opengl-text-rendering/) - Stack Overflow: [Better Quality Text in WebGL](https://stackoverflow.com/q/25956272/23649) - https://github.com/mapbox/tiny-sdf - [deck.gl TextLayer](https://github.com/uber/deck.gl/tree/78891632763fa655bec04d320fec3c66c85f6365/modules/layers/src/text-layer) - [mapbox-gl-js GlyphManager](https://github.com/mapbox/mapbox-gl-js/blob/26a47e4e11dec83dc6d6190a904224c290c74f96/src/render/glyph_manager.js) - https://github.com/dy/font-atlas-sdf ## Test plan Added stories/screenshot tests and docs page demo. Unfortunately the code is not too easily amenable to unit testing (other than perhaps the font atlas memoization). ## Versioning impact This PR is purely additive, so doesn't necessitate a major version bump. The GLText command might eventually replace Text, but we'd like to get some mileage on it first — we'll be testing it in Webviz, and would love for any external users to give it a try as well. A few areas for improvement would probably need to be addressed before deprecating the DOM-based Text command: solid rectangular background instead of outline (or at least improved visibility at small sizes); highlight ranges to replace browser-native ⌘F; hitmap support.
Minor cleanup — following up on @vidaaudrey's feedback from cruise-automation#291
This adds support for connecting to a rosbridge_server over a WebSocket connection. By default it connects to ws://localhost:9090, but you can change this by using the `?rosbridge-websocket-url=…` query parameter. In the future we will add better UI and documentation for this. This fixes cruise-automation#118 cruise-automation#170 cruise-automation#209. Other fixes: - Fixed not being able to select stacked objects in the 3D panel. - Various improvements to the rosout panel.
And also add Google Analytics
Changelog: - Added docs to top right bar - Added connection status to top right bar - Added Global Variables panel - Added query parameters to load layouts and global variables - Added Google Analytics
Since “try” implies that this is just a demo version of the app, when it’s actually our intended production version. “app” communicates that a bit better. I left a page with a redirect that preserves query parameters under `/try` so that any existing applications will keep working. Test plan: tried this locally, and did a search of “/try” and “try/“ in our codebase, which I think should cover all references.
Changelog: - Added error dialog with instructions when connecting to an insecure WebSocket. - Improved documentation. - Stylistic improvements to various panels.
…n#306) To communicate better our direction with the app.
Tiny consistency fix, it just bugged me that for webviz.io the title was "Webviz" but for webviz.io/app it's "webviz". We use the lowercase version in the title bar so I figured I'd just use that for the main page as well. 🙃
Changelog: - Fixed bug in 2d panel rendering. - Improved styling on Global Variables and Internals panels. - Better demo layout.
This flow type was missing for a while, causing a bunch of flow errors to pile up. Remove so that we can have Command fully typed. Test plan: existing stories and functional integration tests should be enough Versioning impact: This can go out with the next version release
Changelog: - Some minor improvements to some panels - Updated follow TF to include "map"; fixes cruise-automation#309
We already proved that compressjs works as a bz2 decoder in the rosbag.js tests: https://github.com/cruise-automation/rosbag.js/blob/68526faa242bb76943b6e42fa452f1eadb6cbc73/src/bag.test.js#L175-L178 But it wasn't imported in webviz, so bz2-compressed bags (such as the ones at https://vision.in.tum.de/data/datasets/rgbd-dataset/download#freiburg3_cabinet) didn't work by default. It was almost very straightforward to add, except that a webpack/AMD module issue (webpack/webpack#5316) prevents us from actually using compressjs in our webpack build. I worked around it by using a string-replace-loader to just remove the offending line. It's a pretty horrible hack, but it works...let me know if you have any better suggestions.
I'm seeing an error in our logs: "(regl) can not resize a framebuffer which is currently in use" in the readHitmap function. Fix by debouncing the readHitmap function because the framebuffer can only be used in one function at a time. Also add caching to our readHitmap function: if we haven't repainted or changed the pixel that we're looking at, we return the previous result. Test plan: test added for queuePromise for caching. Testing that caching actually works (an implementation detail) seems a bit difficult right now given our test harness. Release plan: minor release required
* Add custom highlight color prop * Add new story * Update default color * Minor update to story | add comments * Fix lint * Clean up based on feedback * update story
Ran into an issue where tests started failing in my internal PR because this version was out of date. Updating this seems to pass all the tests still, and should unblock my internal PR.
Adds `<TopicToRenderMenu>` to the RosOut panel. No version impact (backward compatible).
Add this line, which is required to get internal CI to pass so that we can add this worker to the open-source version.
Just mock out every worker-loader call in Jest, because Jest doesn't like worker calls.
## Summary We'd like to be able to run custom setup code for storybook to support new features we're adding internally. For now it'll just be a no op. ## Test plan Tested build and storybook locally, brought over internally repo and confirmed we can use this change to address our current issues. ## Versioning impact No, only a test change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elgohr/Publish-Docker-Github-Action@master is not supported anymore