Remove epicscorelibs.path dependency on compiler#43
Remove epicscorelibs.path dependency on compiler#43AlexanderWells-diamond merged 1 commit intomasterfrom
Conversation
98ec98d to
573058f
Compare
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
This appears to not work as expected as it does not suppress the logging messages; I still see the messages appear when following the instructions in this comment.
This is after a pip install -e . of this branch checkout.
The instructions provoke it by doing a direct import of |
|
Ah understood, my reproduce wasn't accurate to the actual production issue. As I think further changes are incoming based on discussion in the issue, I'll hold off further review at the moment. |
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
I think these changes are good, but I would like to see the commit message and PR title / description updated to better reflect what was done.
I'm also not sure why the version number appears to be marked as a change; the master version of setup.py definitely already has the version with a2 on the end...
Before this commit, an import of epicscorelibs.path would compute some variables, including about the compiler, to determine the OS_CLASS. However this was unused except in tests. This commit removes epicscorelibs.path.OS_CLASS and replaces references to it with platform.system() instead.
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
All looks good now
Before this commit, an import of
epicscorelibs.pathwould compute some variables, including about the compiler, to determine theOS_CLASS. However this was unused except in tests. This commit removesepicscorelibs.path.OS_CLASSand replaces references to it withplatform.system()instead.Fixes #42, fixes #41