Conversation
4bafade to
6d65ea6
Compare
…ew tag and action components as well
Replace custom DataTable.vue and Rancher SortableTable across all list, detail, and page views with the trailhand data-table web component for consistency with the design system. Extract all shared cell renderers into utils/table-formatters.ts, eliminating duplicated DOM construction logic across components. Helpers cover state tags, router links, commit SHA/author cells, app routes, and build progress cells. Apply dark mode hover CSS variables to every data-table instance. Configure vue.config.js isCustomElement to suppress Vue compiler warnings for web component tag names.
6d65ea6 to
5b9de2e
Compare
| label: t('tableHeaders.description'), | ||
| width: '450px', | ||
| sortable: false, | ||
| formatter: (_v: any, row: any) => { |
There was a problem hiding this comment.
still getting this on failure
dcharles525
left a comment
There was a problem hiding this comment.
Something with the state of the table isn't working, for example when I create a new namespace, I have to manually refresh the page to get it to show. I even see the namespaces api get hit and new data loaded into the store (same for services and configurations). That being said the applications table does seem to update.
When a table does receive an update (like an app being build/deployed) the icon seems to be missing until page refresh.
I also maybe be mis-rememebring but is there only icons in the applications table? Looks like everything else is iconless. Probably just want to be consistent with it best as possible.
- Add renderActions to namespaces, services, and configurations tables - Fix AppProgress description cell formatter (div → flex span) - Fix dark mode sorted column header (add --sortable-table-header-sorted-bg to all data-table CSS blocks) - Fix Lit reactivity: spread [...rows] on all list table :rows bindings so _MERGE polls trigger re-renders - Force-refresh namespaces store immediately after inline modal create
ChangesAction menus
AppProgress description cell formattingThe description column formatter was using a block-level Dark mode sorted column headerThe Table auto-refresh after create/updateTwo issues were preventing tables from reflecting new data:
|
dcharles525
left a comment
There was a problem hiding this comment.
Looks like the only remaining issue is when new data comes in the table doesn't seem to update it? Example below where I see its deployed in the network request but not in the table. Initial creation does show the item in the table though, so that is fixed. A working table would be applications which updated upon receiving new statuses.
… loads Add CONFIGURATION and SERVICE_INSTANCE to the loadCluster kick-start dispatches alongside APP, so data is pre-warmed in the store before the user navigates to those list pages. Simplify configurations and services list pages to only fetch their own type on mount (cross-loading of APP/SERVICE_INSTANCE removed). Add property-touch for status, stateDisplay, and meta in each computed so polling _MERGE updates re-render state tags and age columns in real time.

PR Checklist
Summary
Fixes #
Adopt the trailhand data-table web component across all Epinio UI list, detail, and page views, replacing the legacy custom DataTable.vue and Rancher SortableTable components.
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Light mode - Applications Page