show applications table for every namespace when empty#542
Open
psanghvi17 wants to merge 1 commit intomainfrom
Open
show applications table for every namespace when empty#542psanghvi17 wants to merge 1 commit intomainfrom
psanghvi17 wants to merge 1 commit intomainfrom
Conversation
- Build groupedByNamespace from all namespaces, not only those with apps - Load namespaces on applications page so empty namespaces get a table - Keeps UI consistent and avoids confusion that a namespace does not exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Summary
Fixes #
Show the applications table for each namespace even when it has no applications, so users can confirm the namespace exists and see a consistent layout.
Occurred changes and/or fixed issues
Technical notes summary
groupedByNamespace now:
Reads all namespaces via store.getters'epinio/all'.
Derives the set of namespaces to display based on activeNamespaceCache (or all when no filter is active).
Initializes an empty array for each of those namespaces and then assigns apps into the appropriate group.
Falls back to a single workspace group when nothing is yet loaded, preserving prior behavior.
Namespaces are explicitly fetched on mount of the applications page to keep grouping logic in sync with the current filter state.
Areas or cases that should be tested
Namespace with zero apps
Create a new namespace without deploying any applications.
Open the applications page and confirm the new namespace appears with an empty table.
Applications page – no filter
Navigate to the cluster applications page with multiple namespaces, some with apps and some without.
Verify that every namespace appears with a titled applications table; namespaces with no apps show the empty state row instead of no table.
Areas which could experience regressions
Namespace filtering logic: The applications page now depends more directly on activeNamespaceCache and namespace data; incorrect cache state or missing namespace fetch could affect which groups are rendered.
Applications page performance: The additional findAll call for namespaces runs on mount; though lightweight, any issues in that request could affect initial load time or error handling
Screenshot/Video