fix: include limits.h for INT_MAX and INT_MIN#105
Merged
epsilonrt merged 2 commits intoepsilonrt:devfrom Feb 10, 2026
Merged
Conversation
feat: modernize CI/CD, add packaging workflows, man page and contributing guidelines
Signed-off-by: Rui Chen <rui@chenrui.dev>
There was a problem hiding this comment.
Pull request overview
Fixes a macOS/Clang build failure in mbpoll 1.5.4 where INT_MAX/INT_MIN are referenced without including the standard header that defines them.
Changes:
- Add
#include <limits.h>to ensureINT_MAXandINT_MINare available during compilation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Hi @chenrui333 |
Author
Sorry, I missed it (would it better to make dev branch as default branch? what do you think?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeing some build failure against 1.5.4 release