You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
quirks was added in stephane/libmodbus@f0db03d
two years ago.
if it's desired to support older libmodbus versions, this would have to be made conditional at compile-time.
Would be useful indeed! But I think this may not be behavior you want by default, for a reason?
(I'm not sure why libmodbus put it behind a function call, but they may have done it for a reason)
According to their documentation it it not compliant with the protocol, so that could be why.
I think this should be enabled by a flag, instead of having it in always.
i gave my reasoning to not make it optional above, i don't think it's worth adding an option.
if one did that, one should also catch every possible error case that _could _ be prevented by enabling quirks and suggest to enable it (see #87).
but i think that's all kind of moot, as this project seems to be dead anyway.
Made a pr (#99 ) to add conditional quirk support.
Project may be dead but I have my local working version at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mbpoll, being a tool likely used for testing/debugging, should give it's users access to all possible options, without forcing them to recompile.