Open
Conversation
eivindjahren
force-pushed
the
fix_util_clear_directory
branch
from
363784d to
b814384
Compare
Since TestArea would call with unlink_root equal to true, strict_uid had no effect and is therefore equivalent to std::filesystem::remove_all().
eivindjahren
force-pushed
the
fix_util_clear_directory
branch
from
b814384 to
27b7b60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve https://github.com/equinor/resdata/security/code-scanning/6
Note that this is just an equivalent function call, but has different behavior when it is not have correct permissions. In that case you now get a failure where before you got a silent failure.