Ensure get_geo_layer does not return dangling ref#1130
Merged
eivindjahren merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
SAKavli
reviewed
Mar 3, 2026
| def get_geo_layer(self): | ||
| """Returns the underlying geometric layer.""" | ||
| return self._get_layer() | ||
| return self._get_layer().setParent(self) |
There was a problem hiding this comment.
I have very little context of this library.
When I read this code I would image a set method would return None.
Is this not true in this case?
There was a problem hiding this comment.
Aka if it should have been among the lines:
layer = self._get_layer()
layer.setParent(self)
return layerIf you know what I mean
Collaborator
Author
There was a problem hiding this comment.
It is equivalent as it does return self :)
SAKavli
approved these changes
Mar 3, 2026
SAKavli
left a comment
SAKavli
left a comment
There was a problem hiding this comment.
I'm sure this can be merged. Had a small question though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1124