Refactor fault block layer.cpp

[eivindjahren]

Note that in particular this changes util_abort to .at() out-of-range exceptions in some cases.

[Copilot]

Pull request overview

This PR refactors the fault_block_layer implementation to use C++ RAII patterns and adds/updates tests to validate behavior after the refactor.

Changes:

• Introduces make_<type>_vector(...) and make_layer(...) helpers that return std::unique_ptr with the correct deleter.
• Refactors fault_block_layer internals from int_vector_type/vector_type to std::vector + std::unique_ptr.
• Adds a comprehensive fault_block_layer Catch2 test suite and updates existing layer tests to use the new helpers.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
lib/vector_template.hpp.in	Declares make_@TYPE@_vector(...) factory returning std::unique_ptr.
lib/util/vector_template.cpp.in	Defines make_@TYPE@_vector(...) factory.
lib/include/resdata/layer.hpp	Declares make_layer(...) factory.
lib/resdata/layer.cpp	Defines make_layer(...).
lib/resdata/fault_block_layer.cpp	Refactors fault_block_layer storage/ownership to std::vector + unique_ptr.
lib/tests/test_layer.cpp	Updates tests to use make_layer and make_int_vector(...).
lib/tests/test_fault_block_layer.cpp	Adds new Catch2 tests covering fault_block_layer behaviors.
lib/CMakeLists.txt	Adds the new test file to the test suite target.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.