Draft
Conversation
- Add CountyMapPopup component with full interactivity - Add showCountyMapOnClick prop to enable county map display - Add countyData prop for providing county information - Add countyMapWrapper prop for custom popup styling - Add onCountyClick callback for county interactions - Include sample county data for Istanbul, Ankara, and Izmir - Export county data separately for tree-shaking support - Add comprehensive test coverage for new features - Update README with county map usage examples Co-authored-by: erdigokce <17235148+erdigokce@users.noreply.github.com>
- Improve accessibility with ARIA attributes and ESC key support - Add consistent CountyType usage in API - Document placeholder nature of sample county data - Add test for ESC key functionality - Add test for accessibility attributes Co-authored-by: erdigokce <17235148+erdigokce@users.noreply.github.com>
Co-authored-by: erdigokce <17235148+erdigokce@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add county map display when a city is clicked
feat: add county map popup on city click
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a city is clicked, display a popup showing its county (ilçe) map. Feature is opt-in via prop and county data must be explicitly imported to avoid bundle bloat.
Changes
New Component
CountyMapPopup: Modal overlay with interactive county SVG, supports hover/click/tooltips, includes ARIA attributes and ESC key handlingNew Props
showCountyMapOnClick: Enable county map feature (default:false)countyData: Record of county data keyed by city IDcountyMapWrapper: Custom wrapper for popup stylingonCountyClick: Callback with county and city parametersData Structure
CountyType:{ id, name, path }CountyData:{ cityId, cityName, counties }turkey-map-react/lib/data/countiesUsage
Note: Sample county data uses placeholder rectangular paths. Production use requires real geographic SVG data.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.