Fix for apps that will change env['PATH_INFO']#17
Open
gaganawhad wants to merge 1 commit intoericallam:masterfrom
Open
Fix for apps that will change env['PATH_INFO']#17gaganawhad wants to merge 1 commit intoericallam:masterfrom
gaganawhad wants to merge 1 commit intoericallam:masterfrom
Conversation
Owner
|
I just merged another patch that I think should solve this issue too. If you get a chance could you test it out and report back? |
|
i had this problem too, described here sidekiq/sidekiq#1514 the problem goes away with 01861d9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: So I am using font_assets along with sidekiq and it seems that sidekiq's web interface is changing the value of
env['PATH_INFO']to a blank string, which then breaks things.caveat: I am not at expert at RACK so I am not sure that this fixes the problem at the root. Also, I am not really sure if sidekiq should be changing the
env.This is a first attempt at a fix. The test suite passes. I am not sure if you want to add a test case for apps that change the
env, so I didn't add one.Another possible fix might be to allow for
env['PATH_INFO']to hold a blank string but then again, I am not exactly sure what exactly the culprit is.