Remove options http method interception#45
Open
alexanderfrankel wants to merge 2 commits intoericallam:masterfrom
Open
Remove options http method interception#45alexanderfrankel wants to merge 2 commits intoericallam:masterfrom
alexanderfrankel wants to merge 2 commits intoericallam:masterfrom
Conversation
Author
|
Looks like this could be a dup of #18. I can probably help out with some specs if needed. Also, if the interception is needed, can you please explain. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly returning a 200 response code when
env["REQUEST_METHOD"] == OPTIONScan introduce a dependency in the order an application's middleware is executed.Specifically, if a different intended response for an OPTIONS request is implemented (like a 405) in another piece of middleware, it MUST come before
font_assetsmiddleware in the stack or it will never get executed.Happy to discuss further : ) and apologies if I am missing the reason why this OPTIONS request interception if necessary for
font_assetsto work properly. Please enlighten! Thanks!