Add a confirmation dialog when removing torrent #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3b20070.
Owner
|
Thanks for your contribution! I understand the reason for adding this. On the other hand, it's a UI obstacle (albeit small). I'll look at the code later. I'm on leave at the moment. |
|
@erickok I would be happy for a big space between to 2 selections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eric,
This fork adds a confirmation dialog when removing torrents like uTorrent/qBitTorrent web client. One day, sleepy me deleted a rare torrent I was seeding, downloaded for many days painstakingly over 512 kbps "broadband"(#ThirdWorldProblems). I hit "Remove with data" instead of "Remove torrent", since the buttons were too close to each other. Here's a fix for that.
Hope this confirms with your coding guidelines, let me know if there are problems -- will be happy to fix. Haven't translated newly added strings, I don't know how to.
Thanks!