Add walker and hamming and tests for them #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubEF
reviewed
Dec 18, 2025
Collaborator
KubEF
left a comment
KubEF
left a comment
There was a problem hiding this comment.
Честно говоря, это всё очень сильно пахнет нейросеточным кодом
Comment on lines
+16
to
+18
| result = sum(probs) | ||
| if not(abs(result - 1.0) < 1e-6): | ||
| raise ValueError("Сумма вероятностей должна быть близка 1") |
Collaborator
There was a problem hiding this comment.
Почему "близка"? Она должна быть ему равна
| from collections import deque | ||
|
|
||
| class WalkersAlias: | ||
| def __init__(self, events_and_probs): |
Collaborator
There was a problem hiding this comment.
Названия переменных очень странные. Вы вообще не используете принятую у нас терминологию: донор, рецепиент, барьер -- всего этого нет
| @@ -0,0 +1,66 @@ | |||
| def reducent_bits(n): | |||
| """ | |||
| Рассчитывает редуцентные биты p | |||
Collaborator
There was a problem hiding this comment.
Что такое "редуцентные" биты? Документация должна пояснять функцию. Почему возвращает число, а не список, если она рассчитывает биты?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ни в какую не хочет уолкер работать с рандомом