-
Notifications
You must be signed in to change notification settings - Fork 52
feat: schema v3 iteration #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
43081j
wants to merge
7
commits into
main
Choose a base branch
from
schema-v3-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first attempt at the new version of the schema.
The major change here is that we'd go from having an array of many
replacements, to one entry per source module with many replacements.
For example:
```ts
{
"type": "module",
"moduleName": "chalk",
"replacements": [
{
"type": "native",
"engines": [
{ "engine": "node", "minVersion": "X.Y.Z" }
],
"url": { "type": "node", "id": "styleText" },
"description": "The `styleText` built-in provides [...]"
}
]
}
```
Contributor
Author
|
i now added sync scripts to use runtime compat data, and web feature data so we have this {
"type": "native",
"webFeatureId": "fetch",
"engines": [
{
"engine": "chrome",
"minVersion": "42"
},
{
"engine": "chrome_android",
"minVersion": "42"
},
{
"engine": "edge",
"minVersion": "14"
},
{
"engine": "firefox",
"minVersion": "39"
},
{
"engine": "firefox_android",
"minVersion": "39"
},
{
"engine": "safari",
"minVersion": "10.1"
},
{
"engine": "safari_ios",
"minVersion": "10.3"
}
],
"url": {
"type": "mdn",
"id": "Web/API/Fetch_API"
},
"description": "Use native fetch"
},and this from the runtime data: {
"type": "native",
"nodeFeatureId": {
"moduleName": "node:buffer",
"exportName": "Buffer"
},
"engines": [
{
"engine": "cloudflare",
"minVersion": "24.9.0"
},
{
"engine": "deno",
"minVersion": "24.9.0"
},
{
"engine": "vercel",
"minVersion": "24.9.0"
},
{
"engine": "netlify",
"minVersion": "24.9.0"
}
],
"url": {
"type": "e18e",
"id": "buf-compare"
},
"description": "Use native Buffer.compare"
} |
Contributor
Author
|
so i dont forget:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at the new version of the schema.
The major change here is that we'd go from having an array of many
replacements, to one entry per source module with many replacements.
For example: