Skip to content

08 Custom-token: At least add nonce to prevent exploiting admin signature #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HyunggyuJang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

08 Custom-token: At least add nonce to prevent exploiting admin signature #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion 08-custom-tokens/src/BasicTokenContract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ import {
UInt64,
PublicKey,
Signature,
UInt32,
} from 'snarkyjs';

const tokenSymbol = 'MYTKN';

export class BasicTokenContract extends SmartContract {
@state(UInt64) totalAmountInCirculation = State<UInt64>();
@state(UInt32) mintNonce = State<UInt32>();

deploy(args: DeployArgs) {
super.deploy(args);
Expand Down Expand Up @@ -44,11 +46,13 @@ export class BasicTokenContract extends SmartContract {
this.totalAmountInCirculation.assertEquals(totalAmountInCirculation);

let newTotalAmountInCirculation = totalAmountInCirculation.add(amount);
let nonce = this.mintNonce.get();
this.mintNonce.assertEquals(nonce);

adminSignature
.verify(
this.address,
amount.toFields().concat(receiverAddress.toFields())
amount.toFields().concat(...receiverAddress.toFields(), ...nonce.toFields())
)
.assertTrue();

Expand All @@ -57,6 +61,7 @@ export class BasicTokenContract extends SmartContract {
amount,
});

this.mintNonce.set(nonce.add(1));
this.totalAmountInCirculation.set(newTotalAmountInCirculation);
}

Expand Down
7 changes: 6 additions & 1 deletion 08-custom-tokens/src/WhitelistedTokenContract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
Signature,
Poseidon,
MerkleWitness,
UInt32,
} from 'snarkyjs';

class MerkleWitness20 extends MerkleWitness(20) {}
Expand All @@ -19,6 +20,7 @@ const tokenSymbol = 'MYTKN';

export class WhitelistedTokenContract extends SmartContract {
@state(UInt64) totalAmountInCirculation = State<UInt64>();
@state(UInt32) mintNonce = State<UInt32>();
@state(Field) whitelistTreeRoot = State<Field>();

deploy(args: DeployArgs) {
Expand Down Expand Up @@ -54,11 +56,13 @@ export class WhitelistedTokenContract extends SmartContract {
this.totalAmountInCirculation.assertEquals(totalAmountInCirculation);

let newTotalAmountInCirculation = totalAmountInCirculation.add(amount);
let nonce = this.mintNonce.get();
this.mintNonce.assertEquals(nonce);

adminSignature
.verify(
this.address,
amount.toFields().concat(receiverAddress.toFields())
amount.toFields().concat(...receiverAddress.toFields(), ...nonce.toFields())
)
.assertTrue();

Expand All @@ -67,6 +71,7 @@ export class WhitelistedTokenContract extends SmartContract {
amount,
});

this.mintNonce.set(nonce.add(1));
this.totalAmountInCirculation.set(newTotalAmountInCirculation);
}

Expand Down