Refactoring externalcas plugin to improve readability and testability #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the externalcas package to enhance code quality through better separation of concerns and improved testability while preserving all existing functionality. Changes: - Config caching: Parse and validate AcmeProxyConfig once instead of twice per request (eliminated duplicate unmarshaling bug) - Add config validation with Validate() method and timeout helpers (HTTPTimeout, RequestTimeout) - Extract validation functions: ValidateCreateCertificateRequest and ValidateRevokeCertificateRequest for independent testing - Make SplitCertificateBundle public to enable reuse and direct testing - Introduce ACMEClient interface with legoClientAdapter for dependency injection and mock-based testing - Add comprehensive unit tests for validation, config, and certificate processing with mock ACME client Benefits: - Config parsed once and cached (performance + bug fix) - All validation logic independently testable - Certificate processing testable without network calls - No breaking changes to public API or apiv1 interface - Plugin registration pattern preserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(externalcas): enhance testability and fix config parsing
I used Claude Code to assist me with refactoring although I manually reviewed & tested all the proposed changes.