Skip to content

fix(bmi270): correct interrupt pin configuration logic #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finger563 merged 1 commit into from
Dec 8, 2025
+20 −9
Merged

fix(bmi270): correct interrupt pin configuration logic #567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions components/bmi270/include/bmi270.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,17 +433,28 @@ class Bmi270 : public espp::BasePeripheral<uint8_t, Interface == bmi270::Interfa
/// @param ec The error code to set if an error occurs
/// @return True if interrupts were configured successfully, false otherwise
bool configure_interrupts(const InterruptConfig &config, std::error_code &ec) {
// Configure interrupt pin behavior
uint8_t int_io_ctrl =
(static_cast<uint8_t>(config.active_level) << 1) | static_cast<uint8_t>(config.output_type);

if (config.pin == InterruptPin::INT1) {
write_u8_to_register(static_cast<uint8_t>(Register::INT1_IO_CTRL), int_io_ctrl, ec);
} else {
write_u8_to_register(static_cast<uint8_t>(Register::INT2_IO_CTRL), int_io_ctrl, ec);
// Configure interrupt pin electrical behavior (Output Enable | Output Type | Active Level)
// Bit 3 is Output Enable, which must be set to 1 for the pin to drive the line.
uint8_t int_io_ctrl = (1 << 3) |
(static_cast<uint8_t>(config.output_type) << 2) |
(static_cast<uint8_t>(config.active_level) << 1);

auto pin_reg = (config.pin == InterruptPin::INT1) ? Register::INT1_IO_CTRL : Register::INT2_IO_CTRL;
write_u8_to_register(static_cast<uint8_t>(pin_reg), int_io_ctrl, ec);
if (ec) return false;

// Map interrupt features to pins
uint8_t int_map_data = 0;
if (config.enable_data_ready) {
// Map Data Ready interrupt to the selected pin
// Bit 2: Data Ready -> INT1, Bit 6: Data Ready -> INT2
int_map_data |= (config.pin == InterruptPin::INT1) ? (1 << 2) : (1 << 6);
}

return !ec;
write_u8_to_register(static_cast<uint8_t>(Register::INT_MAP_DATA), int_map_data, ec);
if (ec) return false;

return true;
}

protected:
Expand Down