Skip to content

feat: add extraEnv for httpbingo chart#143

Open
plumdog wants to merge 1 commit intoestahn:mainfrom
plumdog:issue-142-httpbingo-env-vars
Open

feat: add extraEnv for httpbingo chart#143
plumdog wants to merge 1 commit intoestahn:mainfrom
plumdog:issue-142-httpbingo-env-vars

Conversation

@plumdog
Copy link

@plumdog plumdog commented Sep 5, 2023

Purpose

#142

Changes

Testing

$ helm template . --set extraEnv.FOO=bar | yq '. | select(.kind == "Deployment") | .spec.template.spec.containers[0].env'
- name: FOO
  value: "bar"

Code Author Checklist

  • Bump the chart version (Chart.yaml -> version)
  • JSON Schema updated (values.schema.json) - ❗ n/a, no such file for this chart
  • Update README.md via helm-docs (or make prep)
    • no, I get an error: make: helm-docs: No such file or directory
  • Run pre-commit run --all-files via pre-commit (or make prep)
  • Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant