Better handling of large documents in data preview
#1879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documents much easier.
Starting to plumb through progress
monaco editor. Due to both trying to fill up as much width as possible.
travjenkins
commented
Jan 28, 2026
Comment on lines
+58
to
+65
| if (error === null && data) { | ||
| return data.documents.reduce( | ||
| (acc, record) => { | ||
| acc[buildRecordKey(record)] = record; | ||
| return acc; | ||
| }, | ||
| {} as Record<string, JournalRecord<Record<string, any>>> | ||
| ); |
Member
Author
There was a problem hiding this comment.
No big change just trying to get a tiny perf boost.
travjenkins
commented
Jan 28, 2026
Comment on lines
+71
to
+79
| const rows = useMemo( | ||
| () => Object.keys(rowsByKey).map((k) => ({ key: k, id: k })), | ||
| [rowsByKey] | ||
| ); | ||
|
|
||
| const selectedRecordJson = useMemo( | ||
| () => stringifyJSON(rowsByKey[selectedKey]), | ||
| [rowsByKey, selectedKey] | ||
| ); |
Member
Author
There was a problem hiding this comment.
These memos only really help when the data is larger but shouldn't add a bunch of overhead for smaller data sets 🤷
travjenkins
commented
Jan 28, 2026
| 'journals.tooManyBytes.title': `Large documents`, | ||
| 'journals.tooManyBytes.message': `Exceeded the maximum bytes before reaching the desired number of documents. This probably means that your documents are large.`, | ||
| 'journals.tooManyBytesAndNoDocuments.title': `Read limit reached`, | ||
| 'journals.tooManyBytesAndNoDocuments.message': `We reached the limit of how much data a web browser can comfortably read, and didn't find even reach the end of one document! This probably means that your documents are huge.`, |
Member
Author
There was a problem hiding this comment.
This message was worded very odd so changed it.
PR: commenting some potential future work
travjenkins
commented
Jan 28, 2026
Member
Author
There was a problem hiding this comment.
intl component -> hook.
travjenkins
commented
Jan 28, 2026
Member
Author
There was a problem hiding this comment.
This was FRUSTRATING and I just got it working and moved on. Commented with a todo even though it isn't a true todo but something we need to research in the future.
travjenkins
commented
Jan 28, 2026
| }} | ||
| > | ||
| <Box | ||
| // TODO (monaco resize) |
Member
Author
There was a problem hiding this comment.
Marking this because this is close but not exactly the same as the other wrapper.
travjenkins
requested review from
GregorShear
and removed request for
kiahna-tucker
…-too-big-doc-preview
GregorShear
approved these changes
Jan 30, 2026
Contributor
Screen.Recording.2026-01-30.at.1.41.59.PM.mov |
Contributor
Screen.Recording.2026-01-30.at.1.41.33.PM.mov |
simple color change when selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1243
Changes
1243
Misc
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
Large docs in data preview show this warning
Switching to using monaco editor
