Skip to content

Conversation

@travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 30, 2026

Issues

#1773

Changes

1773

  • Check if the user copying the link is logged in with SSO and if so share that login link

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Share link is now sso/login if SSO was used

image

Share link still /login if OAuth was used

image

@travjenkins travjenkins changed the title Travjenkins/bug/better sso support Use sso/login as link to share access when user is logged in with SSO Jan 30, 2026
color={isCopied ? 'success' : undefined}
onClick={() => handleCopy(writeValue)}
onClick={(event) => {
event.stopPropagation();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevent the copy link button from selecting the row when clicked

id: 'cta.inviteLink',
})}
</CopyToClipboardButton>
<span>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handles an issue with passing ref

Comment on lines +15 to +16
const LOGIN_LINK_URL = `${window.location.origin}${unauthenticatedRoutes.login.path}`;
const SSO_LOGIN_LINK_URL = `${window.location.origin}${unauthenticatedRoutes.sso.login.fullPath}`;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was initially wondering if we could do some cool magic and mess with the routes dynamically... but this is much easier and low scope approach.

@travjenkins travjenkins marked this pull request as ready for review January 30, 2026 20:24
@travjenkins travjenkins requested a review from a team as a code owner January 30, 2026 20:24
@travjenkins travjenkins added the change:planned This is a planned change label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:planned This is a planned change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants