This repository was archived by the owner on Dec 12, 2023. It is now read-only.
Fix rpc.enable-admin security vuln when running outside docker#27
Open
Chomtana wants to merge 1 commit intoethereum-optimism:mainfrom
Open
Fix rpc.enable-admin security vuln when running outside docker#27Chomtana wants to merge 1 commit intoethereum-optimism:mainfrom
Chomtana wants to merge 1 commit intoethereum-optimism:mainfrom
Conversation
👷 Deploy request for opstack-docs pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
op-node and op-batcher have
--rpc.enable-adminwhich enables admin API on these RPC. Combined with--rpc.addr=0.0.0.0, this will expose admin API to the public when running outside docker which is a security vulnerability.As @upnodedev has asked in the ticket that
And @sbvegan has spoken to a client engineer
The document is written from docker but users would run it on their own VM. So, I think we shouldn't expose admin API and it would be a security issue if being exposed.