This repository was archived by the owner on Dec 12, 2023. It is now read-only.
added pnpm install command to build optimism monorepo#43
Open
yasindce1998 wants to merge 1 commit intoethereum-optimism:mainfrom
Open
added pnpm install command to build optimism monorepo#43yasindce1998 wants to merge 1 commit intoethereum-optimism:mainfrom
yasindce1998 wants to merge 1 commit intoethereum-optimism:mainfrom
Conversation
Added pnpm install command for building the optimism repo
👷 Deploy request for opstack-docs pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pnpm install command for building the optimism repo
Description
When I was trying to build optimism monorepo using
pnpm buildcommand right after this commandmake op-node op-batcher op-proposer. First it was confusing after then I found out I have to usepnpm installcommand first after then we have to usepnpm buildcommand.Ref: https://stack.optimism.io/docs/build/getting-started/#build-the-optimism-monorepo
Tests
Since it's documentation changes test cases are not needed.
Additional context
Adding
pnpm installcommand beforepnpm buildwould make installation easier otherwise it'll throwNX not found erroralso people confuse withyarn/npm install. So this would help beginners to understand these commands properly.