Skip to content

short address check and dont allow self transfer #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akash-bansal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

short address check and dont allow self transfer #3

akash-bansal wants to merge 1 commit into from

Conversation

@akash-bansal
Copy link

@akash-bansal akash-bansal commented Nov 13, 2017

No description provided.

@akash-bansal akash-bansal mentioned this pull request Nov 17, 2017
Open
@plutoegg
Copy link
Contributor

plutoegg commented Nov 17, 2017

I don't see any reason to necessarily disallow self transfers?

@akash-bansal
Copy link
Author

akash-bansal commented Nov 19, 2017

In my opinion to allow self transfers would lead to wastage of gas. Not sure if this is leaking any security risk.
Adding this would make the contract more robust.
And what about the short address check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akash-bansal @plutoegg