bug: Loosen file path requirement for discover command#31
Merged
Conversation
Previously, we were expecting the path passed to `DiscoverArgument::Path` to be path to a file that already exists. However, it's possible that rust-analyzer will invoke us with a path to a not-yet-existing file if the user has opened a new file in their editor but hasn't yet saved. This commit removes the requirement that this path point to a file on disk to improve UX in this situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were expecting the path passed to
DiscoverArgument::Pathto be path to a file that already exists. However, it's possible that
rust-analyzer will invoke us with a path to a not-yet-existing file if
the user has opened a new file in their editor but hasn't yet saved.
This commit removes the requirement that this path point to a file on
disk to improve UX in this situation.