Skip to content

bug: Use manifest path as reported buildfile #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethowitz merged 1 commit into from
Oct 26, 2025
Merged

bug: Use manifest path as reported buildfile #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ Add the following to your `settings.json`:
"Cargo.toml"
]
},
"rust-analyzer.check.invocationStrategy": "once",
"rust-analyzer.check.overrideCommand": [
"cargo-subspace",
"check", // You can also use "clippy" here
Expand All @@ -115,6 +116,7 @@ also be set via lspconfig.
```lua
["rust-analyzer"] = {
check = {
invocationStrategy = "once",
overrideCommand = {
"cargo-subspace",
"clippy",
Expand Down Expand Up @@ -149,6 +151,7 @@ These settings should be specified in `Settings --> LSP Client --> User Server S
"useWorkspace": false,
"initializationOptions": {
"check": {
"invocationStrategy": "once",
"overrideCommand": [
"cargo-subspace",
"clippy",
Expand Down
17 changes: 1 addition & 16 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,23 +217,8 @@ fn discover(ctx: &Context, discover_args: DiscoverArgs, manifest_path: FilePath<
let metadata = cmd.exec()?;
let project = compute_project_json(ctx, discover_args, metadata, manifest_path)?;

let root = ctx
.cargo()
.arg("locate-project")
.arg("--workspace")
.arg("--manifest-path")
.arg(manifest_path)
.arg("--message-format")
.arg("plain")
.output()?;
let buildfile: PathBuf = String::from_utf8(root.stdout)?.trim().into();
let output = DiscoverProjectData::Finished {
buildfile: Utf8PathBuf::from_path_buf(buildfile).map_err(|e| {
anyhow!(
"Manifest path `{}` contains non-UTF-8 characters",
e.display()
)
})?,
buildfile: manifest_path.to_path_buf(),
project,
};
let json = if ctx.is_tty {
Expand Down