Conversation
allows for implementing a shimmed require.config() as shown in https://github.com/requirejs/example-multipage-shim
|
Thanks for putting the time into formatting this into a pull request. I'm still a little unclear as to the mechanics behind the mode="shim" mode for require_module. In particular, this still looks like something that could be implemented using the existing tools provided by django-require. Manually putting your own require() calls in your templates seems perfectly reasonable, and more clear as to what is actually going on. I'm also a bit confused about the keys in the REQUIRE_COMMON_MODULE setting. In particular, putting in more than one common module seems to raise an error (https://github.com/arctelix/django-require/blob/master/require/storage.py#L163). If a user needs more than one common module, they would be on their own again. |
Perhaps a skype screen cast walk through could help us go through the scenarios more efficiently? I am certainly open to any ideas you have. This was my best try at getting the results i was looking for. |
|
👍 Indeed, multipage-shim is an important functionality of RequireJS. Thx, @arctelix, I'll try your pull request in the next few weeks. |
|
Thanks @arctelix. The travis build is failing after your fixes, could you take a look at that? https://travis-ci.org/etianen/django-require/jobs/21990149 |
|
Oh I thought it was posted april this year but the PR is already a year old. |
|
@thijstriemstra the code works perfectly. I suspect the travis tests failed due to lack of incorporation of the changes. I never got arround to modifying tests since etianen was not convinced it should be incorporated into the master branch. |
|
@selenite29 Did you ever try this out? Curious to see if it worked out for you... |
allows for implementing a shimmed require.config() as shown in
https://github.com/requirejs/example-multipage-shim