Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds type annotations to the _getJSONData method, specifically focusing on improving type safety for Express response objects with generic type parameters. The changes introduce test cases to verify proper typing behavior when using Express responses with custom data structures.
- Adds type tests for Express responses with generic type parameters
- Validates type safety for
createResponseandcreateMocksfunctions with typed responses
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @nicoabie thanks for your PR. I want to make sure this change doesn’t require updating any existing tests that depend on the |
Yes, no need to change any existing tests, it uses any if no type is specified and specification is optional. |
fixes #323