WIP: Add tests for future refactoring#53
Open
joyarzun wants to merge 3 commits intoevancohen:masterfrom
Open
Conversation
joyarzun
force-pushed
the
add-test
branch
6 times, most recently
from
6e8ed56 to
7a05ef2
Compare
Owner
|
Sounds like a good idea to me! @ashishsc? |
Collaborator
|
lgttm ! thanks @joyarzun |
ashishsc
approved these changes
Jul 20, 2017
Owner
|
Jumped the gun there a little bit, pretty sure this is work in progress. You must really want tests ;) |
Collaborator
|
woops. I meant to say lgtm to keep going forward = ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there.
I want to add tests for future refactoring and not breaking anything. The idea is refactoring to isolate the recognizer code and be able to add others streaming services. This is a WIP to know whether it's the right way or not. It's my first time making mocks of Stream. What do you think?