Added GL.Shader.fromURL(vsURL, fsURL) and GL.create({canvas: myCanvas})#10
Open
toaarnio wants to merge 14 commits intoevanw:masterfrom
Open
Added GL.Shader.fromURL(vsURL, fsURL) and GL.create({canvas: myCanvas})#10toaarnio wants to merge 14 commits intoevanw:masterfrom
toaarnio wants to merge 14 commits intoevanw:masterfrom
Conversation
…s: GL.create({ width:800, height:600});
…load the shaders from the given URLs, or failing that, from DOM elements by the given IDs
…ion failed, now fixed
…e resources from being returned from a cache
… has a relative (percentage) width or height
Contributor
|
+1 |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to put my shaders into separate files and load them via XHR, so I added a Shader factory method for that. It's currently limited to synchronous XHR, which is of course not good performance-wise if you have lots of shaders, but it's a start.
Also added the ability to pass a pre-existing canvas to GL.create(), which I've found convenient.