This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Bugfix: Fix channels beong incorrectly returned by getDomains#241
Open
mjftw wants to merge 5 commits intoevent-catalog:mainfrom
Open
Bugfix: Fix channels beong incorrectly returned by getDomains#241mjftw wants to merge 5 commits intoevent-catalog:mainfrom
mjftw wants to merge 5 commits intoevent-catalog:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 0f1f42b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mjftw
force-pushed
the
fix-channels-included-in-getdomains
branch
from
8f785f0 to
9f2cda5
Compare
Contributor
|
Hey @mjftw looks like linting failed. If you run Thanks for the fix BTW! |
Author
Oops missed that - fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I discovered that the dumpCatalog function was returning channels in the list of domains when running it on my catalog.
This seemed wrong, so I dug into the SDK code and found that the getDomains function was also returning channels.
I was able to reproduce this bug with a failing test (added in this PR).
The fix was to include channels in the
ignorelist of used in getDomains, and the test now passes.