Skip to content

Release v0.1#20

Open
exos wants to merge 10 commits intodevelopfrom
release/v0.1
Open

Release v0.1#20
exos wants to merge 10 commits intodevelopfrom
release/v0.1

Conversation

@exos
Copy link
Contributor

@exos exos commented Feb 28, 2026

No description provided.

exos and others added 9 commits April 30, 2020 16:50
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5.
- [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md)
- [Commits](isaacs/minimatch@v3.1.2...v3.1.5)

---
updated-dependencies:
- dependency-name: minimatch
  dependency-version: 3.1.5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the repository for the v0.1 release cycle by bumping package/version metadata, refreshing tooling dependencies, and migrating ESLint configuration to the new flat-config style.

Changes:

  • Bumped package version to 0.1.0-rc4 and updated dependencies/devDependencies (notably ESLint/Jest/TypeScript toolchain).
  • Replaced legacy .eslintrc.js with eslint.config.js (flat config) and added .ncurc.
  • Updated npm publish ignore rules and CI Node.js version.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
package.json Version bump + dependency/devDependency upgrades.
package-lock.json Lockfile refresh reflecting upgraded tooling/deps.
eslint.config.js New ESLint flat-config entry (replacing .eslintrc.js).
.npmignore Updated publish ignore patterns for build artifacts/tests/hooks.
.ncurc Config to prevent npm-check-updates from updating @types/node.
.github/workflows/pr-ci.yml CI Node.js version updated to 24.x.
.eslintrc.js Removed legacy ESLint config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +19 to +55
module.exports = defineConfig([{
languageOptions: {
parser: tsParser,

globals: {
...globals.node,
...jest.environments.globals.globals,
},

ecmaVersion: 2020,
sourceType: "module",
parserOptions: {},
},

plugins: {
jest,
jsdoc,
},

extends: compat.extends("plugin:@typescript-eslint/recommended", "plugin:jsdoc/recommended"),

rules: {
indent: ["error", 4, {
SwitchCase: 1,

FunctionExpression: {
parameters: "first",
},
}],

"@typescript-eslint/no-explicit-any": ["warn"],

"jsdoc/tag-lines": 0,
"padded-blocks": 0,
"no-constant-condition": 0,
},
}]);
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint.config.js is using the flat-config format, but the config object includes an extends key. Flat config doesn’t support extends inside an entry; FlatCompat outputs config objects that need to be spread into the exported array. As-is, ESLint will treat extends as an unknown key and fail to load the config.

Suggested change
module.exports = defineConfig([{
languageOptions: {
parser: tsParser,
globals: {
...globals.node,
...jest.environments.globals.globals,
},
ecmaVersion: 2020,
sourceType: "module",
parserOptions: {},
},
plugins: {
jest,
jsdoc,
},
extends: compat.extends("plugin:@typescript-eslint/recommended", "plugin:jsdoc/recommended"),
rules: {
indent: ["error", 4, {
SwitchCase: 1,
FunctionExpression: {
parameters: "first",
},
}],
"@typescript-eslint/no-explicit-any": ["warn"],
"jsdoc/tag-lines": 0,
"padded-blocks": 0,
"no-constant-condition": 0,
},
}]);
module.exports = defineConfig([
...compat.extends("plugin:@typescript-eslint/recommended", "plugin:jsdoc/recommended"),
{
languageOptions: {
parser: tsParser,
globals: {
...globals.node,
...jest.environments.globals.globals,
},
ecmaVersion: 2020,
sourceType: "module",
parserOptions: {},
},
plugins: {
jest,
jsdoc,
},
rules: {
indent: ["error", 4, {
SwitchCase: 1,
FunctionExpression: {
parameters: "first",
},
}],
"@typescript-eslint/no-explicit-any": ["warn"],
"jsdoc/tag-lines": 0,
"padded-blocks": 0,
"no-constant-condition": 0,
},
}
]);

Copilot uses AI. Check for mistakes.
Comment on lines +40 to +52
rules: {
indent: ["error", 4, {
SwitchCase: 1,

FunctionExpression: {
parameters: "first",
},
}],

"@typescript-eslint/no-explicit-any": ["warn"],

"jsdoc/tag-lines": 0,
"padded-blocks": 0,
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config enables the @typescript-eslint/no-explicit-any rule but @typescript-eslint/eslint-plugin is not registered in the plugins map. In flat config, rules must come from plugins that are explicitly provided in the same config entry (or another entry that applies to the same files), otherwise ESLint will error with “Definition for rule … was not found”.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +4
coverage/*
hooks/*
src/*
tests/*
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ignore patterns like src/* and tests/* only ignore immediate children and will still include nested paths (e.g., src/foo/bar.ts) in the published package. Use directory patterns like src/, tests/, etc. (or src/**) so all nested content is excluded as intended.

Suggested change
coverage/*
hooks/*
src/*
tests/*
coverage/
hooks/
src/
tests/

Copilot uses AI. Check for mistakes.
Comment on lines 22 to 26
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: '24.x'
cache: 'npm'
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is now running on Node 24.x only, but package.json declares support for Node >=20.19.5. Testing only on 24.x can miss breakages for users on the minimum supported runtime; consider using a matrix (e.g., 20.x and 24.x) or aligning engines.node with the CI version.

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 4
{
"name": "@exoshtw/admob-ssv",
"version": "0.1.0",
"version": "0.1.0-rc4",
"description": "Tool for validate AdMob rewarded ads signatures SSV",
Copy link

Copilot AI Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title indicates a Release v0.1, but the package version is set to a release-candidate (0.1.0-rc4). If this PR is meant to publish the final 0.1.0 release, the version should be non-prerelease; otherwise consider adjusting the PR title/description to reflect the RC intent.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants