Skip to content

Conversation

@EvanBacon
Copy link
Contributor

Why

  • App Clip targets require a special endpoint to register a child bundle identifier that's linked to the parent. Without this change, eas corrupts the app credentials by registering the child bundle identifier as a standard app identifier. Once registered, the value cannot be changed, leading to a pretty frustrating flow.

How

  • I added the internal endpoint to apple utils, bumped the package, and added a special case in multi-target signing to register the child bundle id as expected.

Test Plan

Detects App Clips via entitlements and registers App Clip bundle identifiers with parent app relationships. Updates related interfaces and logic to handle App Clip-specific requirements during bundle ID creation.
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@EvanBacon EvanBacon requested a review from byCedric January 10, 2026 21:49
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Size Change: +9.1 kB (+0.02%)

Total Size: 53.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.3 MB +9.1 kB (+0.02%)

compressed-size-action

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.59%. Comparing base (3a7182b) to head (63dd8d9).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...li/src/credentials/ios/appstore/ensureAppExists.ts 5.89% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3300      +/-   ##
==========================================
- Coverage   49.61%   49.59%   -0.02%     
==========================================
  Files         671      671              
  Lines       27972    27991      +19     
  Branches     5780     5793      +13     
==========================================
+ Hits        13876    13879       +3     
- Misses      12906    12921      +15     
- Partials     1190     1191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanBacon EvanBacon merged commit 16767f3 into main Jan 12, 2026
11 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/app-clip-registration branch January 12, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants