Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 87 87
Lines 12185 12185
Branches 637 1057 +420
==========================================
Hits 12185 12185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
left a comment
There was a problem hiding this comment.
Back to your queue to update README.md (or add a CONTRIBUTING.md) that details how to set up the repo for internal/external contribution now that it's more complex than just the implied run of yarn.
9dc1976 to
2eb6595
Compare
wschurman
left a comment
There was a problem hiding this comment.
Back to your queue. Reached out on slack for clarification. In it's current form, I think this would break my development (and therefore likely others) since yarn no longer seems to work.
Why
It's simpler, and makes it easier to run all the tests locally.
e: Also I see it's over 30% faster, from the parallelization.
Test Plan
Everyone can run
mise run cito run all the same checks that CI runs, in parallel. Also I changed the CI workflows to also runtypedocon PRs, to make sure that still works.